Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.10] Update CAPI to v1.4.7 #4042

Merged
merged 1 commit into from
Sep 27, 2023
Merged

[release-1.10] Update CAPI to v1.4.7 #4042

merged 1 commit into from
Sep 27, 2023

Conversation

mboersma
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates CAPI references to use the new v1.4.7 release.

Also updates cert-manager to v1.13.0 to keep that in sync with CAPI.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Update CAPI to v1.4.7

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 26, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (570d1f8) 54.28% compared to head (457588c) 54.28%.
Report is 1 commits behind head on release-1.10.

Additional details and impacted files 
@@              Coverage Diff              @@
##           release-1.10    #4042   +/-   ##
=============================================
  Coverage         54.28%   54.28%           
=============================================
  Files               186      186           
  Lines             18866    18866           
=============================================
  Hits              10242    10242           
  Misses             8069     8069           
  Partials            555      555

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CecileRobertMichon
CecileRobertMichon reviewed Sep 26, 2023
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ef841396b3f239a64b0c6cf99b0da2ebf923fd9c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2023
nojnhuh
nojnhuh reviewed Sep 26, 2023
View reviewed changes
Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mboersma
Copy link
Contributor Author

mboersma commented Sep 27, 2023 •
edited
Loading 

 MachinePool.cluster.x-k8s.io "capz-e2e-9b7810-vmss-mp-0" is invalid:
   .spec.replicas: Invalid value: -52: should be a non-negative integer

Whoa. See here.

@mboersma
Copy link
Contributor Author

/retest

@CecileRobertMichon
Copy link
Contributor

MachinePool.cluster.x-k8s.io "capz-e2e-9b7810-vmss-mp-0" is invalid:
.spec.replicas: Invalid value: -52: should be a non-negative integer

what happened??

@k8s-ci-robot k8s-ci-robot merged commit d9c791d into kubernetes-sigs:release-1.10 Sep 27, 2023
7 checks passed
@mboersma mboersma deleted the capi-one-four-seven branch September 27, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojnhuh nojnhuh nojnhuh left review comments

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees

@CecileRobertMichon CecileRobertMichon

@nojnhuh nojnhuh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
CAPZ Planning
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mboersma @k8s-ci-robot @CecileRobertMichon @nojnhuh